> There may be more than one issue.
>
> Anyway, svn mkdir https://... should be rejected as you're attempting
> to commit a change without providing a commit message with a valid
> ticket.

Oh... um, I'm pretty sure I did have a -m "...message..." in the
actual command line.  

> It should have been rejected in the pre-commit hook... 

I'm not using a pre-commit hook, and I wouldn't want to use one that
rejected all commits without a ticket attached (svn mkdir in
particular)!  That's just not appropriate in our case.

> so the post-commit hook should have not been called at all.  Which
> version of the hooks are you using ?

Hmm...  I'm using a modified copy of... well, I can't say: the hook
doesn't contain a record of its version.  That said, I see two very
significant-looking differences between my hook and the one in
0.11-dev:


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To post to this group, send email to trac-users@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/trac-users?hl=en
-~----------~----~----~----~------~----~------~--~---

@@ -138,13 +147,10 @@
 
     def __init__(self, project=options.project, author=options.user,
                  rev=options.rev, url=options.url):
+        # log('opening default environment:', project)
         self.env = open_environment(project)
-        repos = self.env.get_repository()
-        repos.sync()
+        repos = self.env.get_repository() # will do a `sync` if needed
         
         # Instead of bothering with the encoding, we'll use unicode data
         # as provided by the Trac versioncontrol API (#1310).
-        try:
-            chgset = repos.get_changeset(rev)
-        except NoSuchChangeset:
-            return # out of scope changesets are not cached
+        chgset = repos.get_changeset(rev)
That is, the official one is sync()'ing explicitly instead of assuming
that get_repository() will cause a sync(), and it's explicitly
ignoring NoSuchChangeSet exceptions.  I guess I'll be importing these
changes to my script, since we are using 0.11-dev.


Thanks!

-- 
Dave Abrahams
Boost Consulting
http://www.boost-consulting.com

The Astoria Seminar ==> http://www.astoriaseminar.com

Reply via email to