Remy Blank wrote: > Mmh, now that I re-read the code on trunk, I wonder if we haven't lost > that functionality (automatically calling the base class' __init__()) in > the refactoring... > > Jun, would you mind checking that? I'm pretty sure that the > implementation in 0.12-stable automatically calls inherited > constructors, whereas this isn't the case anymore on trunk. That would > be a regression, and we should restore the functionality.
Scratch that, I must have been dreaming. We have never called the overridden constructor of the base class automatically. But maybe we should? The use case presented here by Chris shows that it's currently awkward to override a Component constructor, as you have to pass the environment to a method taking no arguments, and I'm not even sure it's going to work on 0.12-stable due to maybe_init() registering the derived component instance with the key of the base class. Funnily enough, this case has never occurred in Trac, as we only rarely inherit from a Component subclass, and we never override the constructor. Thoughts? -- Remy
signature.asc
Description: OpenPGP digital signature
