> -----Original Message----- > From: [email protected] On Behalf Of Samuel Halliday > Sent: 06 September 2012 15:37 > To: [email protected] > Subject: Re: [Trac] Trac dev and post commit hooks > > (content appears at bottom)
Thanks! > On 6 Sep 2012, at 08:18, "Cooke, Mark" <[email protected]> wrote: > > > [Note: please post in-line or at the bottom...] > > > >> On 4 Sep 2012, at 08:09, "Cooke, Mark" > <[email protected]> wrote: > >> > >>>> On 3 Sep 2012, at 08:01, "Cooke, Mark" wrote: > >>>>>> the defaults from > >> http://trac.edgewall.org/wiki/CommitTicketUpdater > >>>>> > >>>>> Looking at that page appears to confirm my suspicion that > >>>> you need to set the `envelope` option. Try doing a commit > >>>> using the log message `[fixes #34]` (using the apparently > >>>> default `[]` envelope. If that works, just define the > >>>> envelope option to be empty and you should be back where you > >>>> want to be... > >>>> > >>>> -----Original Message----- > >>>> From: [email protected] On Behalf Of Samuel Halliday > >>>> Sent: 03 September 2012 20:37 > >>>> To: [email protected] > >>>> Subject: Re: [Trac] Trac dev and post commit hooks > >>>> > >>>> I added the envelope setting, and tried a "[refs #30]" commit > >>>> message (also without the square brackets). Again, shows up > >>>> as a clickable link in timeline but no mention in the > >> ticket itself. > >>>> > >>> ...you removed most of the historical context to this > >> email? I use email and don't store old messages, so I don't > >> have the old info on your config so far. > >>> > >>> I think I would suggest that you (a) set _all_ the options > >> referenced in the www help page (link above) rather than rely > >> on the defaults, (b) restart your server to make sure they're > >> used, (c) try it again and (d) if it still doesn't work, show > >> us the config and commit message you used and say what did > >> and didn't happen. > >>> > >>> For your ref, here are my settings (but note that I don't > >> use `close` from commit as we have a separate testing phase > >> in our workflow):- > >>> > >>> [components] > >>> tracopt.ticket.commit_updater.* = enabled > >>> > >>> [ticket] > >>> commit_ticket_update_envelope = > >>> #commit_ticket_update_commands.close = > >>> commit_ticket_update_commands.refs = <ALL> > >>> commit_ticket_update_check_perms = true > >>> commit_ticket_update_notify = true > >>> > >>> ....this should add a ref for any `#<number>` bit of text > >> to ticket <number>, checking that the commiter has rights to > >> update the ticket (do your svn and trac usernames match?). > >>> > >>> ~ mark c > >> > >> -----Original Message----- > >> From: [email protected] > >> [mailto:[email protected]] On Behalf Of Samuel Halliday > >> Sent: 05 September 2012 20:22 > >> To: [email protected] > >> Subject: Re: [Trac] Trac dev and post commit hooks > >> > >> Added all settings, still not updating the ticket :-( > >> > >> -- > >> Sam > > > > Do you have TRAC_ADMIN permission for your trac? If so, go > to the `About Trac` link (under the search button) and make > sure that the settings displayed there match what you are > expecting them to be (especially the [components], [ticket] > and [trac] repository_ settings). Paste them in a reply if > you can, along with the exact log message(s) you have tried > that did not work. > > > > If you are not TRAC_ADMIN and you have > `commit_ticket_update_check_perms = true` are you sure you > can edit the ticket comments OK? > > > > Are your trac and svn usernames identical? > > > > Please also post your svn post-commit hook script ~ how > have you tested that it works for whichever user the apache > daemon runs as? The svn commit still succeedes even if the > post-commit hook fails (as it runs by definition after the > commit completes) so that might explain why svn works but the > trac bit doesn't. On *nix this is usually a permissions > issue, can also be on Windows depending on how you are setup > (it helps if you tell us what platform you are on and exactly > which versions ~ if you did earlier you removed that info > from the text). > > > > In your trac instance, set the Admin > Logging > configuration to DEBUG level then try again and see if any > errors are reported. > > > > Thanks Mark! It was a permission problem, I had forgotten to > change the owner of the post-commit hook. Glad to have got you sorted. > Now all works fine. The thing that was confusing me the most > was that the history was showing up, so I have now learnt > that the timeline doesn't depend on the hook running successfully. Well, that may depend if you are using the "old" or "new" repo synchronisation mechanism:- http://trac.edgewall.org/wiki/TracRepositoryAdmin#ExplicitSync ...as that page states, if the old per-request sync is used (as I suspect yours is): "Note that in this case, the changeset listener extension point is not called, and therefore plugins using it will not work correctly." As you are using the post-commit hook, you want to set `repository_sync_per_request` to False. ~ mark c -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/trac-users?hl=en.
