On Wednesday, May 27, 2015 at 10:32:32 AM UTC-4, RjOllos wrote: > > On Wed, May 27, 2015 at 3:06 AM, Mo <[email protected]> wrote: > >> Am Freitag, 22. Mai 2015 16:56:55 UTC+2 schrieb Jun Omae: >> >> That issue has been reported in https://trac-hacks.org/ticket/11664. >>> That plugin doesn't work with PostgreSQL. Also, the issue is not fixed >>> yet. >>> >> >> >> Hi, the ticket is about migration. But how can PostgreSQL break any >> plugin? >> > > The ticket may be about migration, but the underlying issue is caused by > incorrect database API use by the plugin and will affect its standard > functions as well. The SQL syntax is different for SQLite, PostgreSQL and > MySQL. The Trac database API abstracts away these difference, however the > plugin is not making proper use of the Trac database API. > http://trac.edgewall.org/wiki/TracDev/DatabaseApi#RulesforDBAPIUsage > > I'm working on fixing the issues and a new version of the plugin should be > available in a few days. Please follow ticket #11168 to see when new > versions of the plugin are available. > https://trac-hacks.org/ticket/11168 > > - Ryan >
To expand on this a bit further, CodeReviewerPlugin's CommitTicketUpdater-equivalent component adds an entry to the database with a changeset-to-ticket relation. The entry includes a timestamp. In the ticket Jun referred to, he noted that the column for the timestamp was using an integer type that was too small for the timestamp, leading to the DataError. On SQLite there was no error, however on MySQL there was an open ticket about timestamps being incorrect (0), which I also assumed to be an effect of the overflow. After some major changes to the CodeReviewerPlugin it seems to be working as well on PostgreSQL as it does on SQLite. There is one major issue that I know of, comments disappear and reappear (1). After #11163 is resolved, I appreciate if anyone is able to test and report issues. Please open new tickets for any issues that are found. Note that all the recent changes have been made on the 1.0 branch (2). I consider the plugin to be alpha quality and advise against installing it on production instances of Trac. That said, it may be the best option at the moment for integrated code review, and my hope is that the plugin evolves into a robust solution. Testing and feedback is important to make that happen. (0) https://trac-hacks.org/ticket/10806 (1) https://trac-hacks.org/ticket/11163 (2) https://trac-hacks.org/svn/codereviewerplugin/1.0/ -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/trac-users. For more options, visit https://groups.google.com/d/optout.
