On Sunday, March 26, 2017 at 2:49:11 PM UTC-7, RjOllos wrote: > > > > On Friday, March 24, 2017 at 11:34:45 PM UTC-7, Mingxing Tian wrote: >> >> >> >> 在 2017年3月25日星期六 UTC+8下午2:29:48，RjOllos写道： >>> >>> From: Mingxing Tian >>> Sent: Friday, March 24, 23:17 >>> Subject: [Trac] trac-code-comments-plugin:Uncaught ReferenceError: id is >>> not defined >>> To: Trac Users >>> >>> I think it is javascript, please help fix it as soon as possible. >>> >>> Where is the source code for that plugin? Please give a URL. >>> >>> -Ryan >>> >> >> github:`https://github.com/Automattic/trac-code-comments-plugin` >> <https://github.com/Automattic/trac-code-comments-plugin> >> >> This plugin is very important to me because our team needs to record the >> results of the review when doing the code review. This plugin may make the >> record change easier. To tell the truth, I have discussed the way to create >> a new order and record the problem. Kind of way a bit old fashioned >> > > > Are you running the latest version of the plugin? It appears the issue was > reported here, and said to be fixed: > https://github.com/Automattic/trac-code-comments-plugin/issues/37 > > - Ryan >
Looks more closely at issue 37, they claim the fix is in the unmerged pull request: https://github.com/Automattic/trac-code-comments-plugin/pull/26 If that fixes the issue for you, you should ask them to merge it. The author claims they are still maintaining the plugin: https://github.com/Automattic/trac-code-comments-plugin/issues/53 If there's no reply or movement I may just fork it to the trac-hacks org in a few weeks. It looks like the plugin is incompatible with Trac 1.2: https://github.com/Automattic/trac-code-comments-plugin/blob/master/code_comments/comment.py#L131 - Ryan -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/trac-users. For more options, visit https://groups.google.com/d/optout.
