On Wednesday, April 26, 2017 at 11:09:35 PM UTC-7, Peter Suter wrote: > > On 27.04.2017 06:53, Dave Huang wrote: > > Thanks, ReplyToTicketSubscriber works well! Is there a way to enable it > > by default (e.g., in the notification-subscriber section of trac.ini)? I > > tried adding "notify_replies = ReplyToTicketSubscriber" to the > > notification-subscriber section, but it didn't show up in the Default > > rules section of the Preferences Notifications tab. > > > > I noticed that in the plugin's source, the default_subscriptions > > function returned [], whereas the INotificationSubscribers that are in > > the Trac core all do something like "return > > NotificationSystem(self.env).default_subscriptions(klass)" (e.g., > > > https://trac.edgewall.org/browser/branches/1.2-stable/trac/ticket/notification.py?rev=15714#L307). > > > > > > > > I tried changing ReplyToTicketSubscriber's default_subscriptions to do > > the same thing, which made it show up as a Default rule in the > > Notifications Preferences, but I don't actually get any notifications > > from it (whereas if I add it under Subscription rules, it works as > > expected). I haven't tried looking into it further; I wanted to check > > with the mailing list first to see if y'all had any suggestions :) > > > > You're probably on the right track, but also need one more thing: > Add back the "default_subscriptions()" handling in "matches()". > I removed that part[1] because the part you now added was still missing. > (Please add them both to the wiki page after confirming that it works.) > > [1] The first chunk in > > https://trac.edgewall.org/wiki/CookBook/Notification/Subscriptions?action=diff&version=11&old_version=10 > > > > Peter >
Saw that it was edited today in: https://trac.edgewall.org/wiki/CookBook/Notification/Subscriptions?version=16 - Ryan -- You received this message because you are subscribed to the Google Groups "Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/trac-users. For more options, visit https://groups.google.com/d/optout.
