Thank you.

Another small patch attached that I needed for including an HTML page with 
UTF-8 encoding as `Include(http://www.example.com/page.html)` .
Without decoding, the page is included as bytes with all special characters 
escaped.
It might be better to enter the encoding as a parameter.
--
ales horak


Dne středa 17. září 2025 v 4:13:15 UTC+2 uživatel Jun Omae napsal:

Thanks for the feedback.
I've committed the patch in [18706] <https://trac-hacks.org/changeset/18706>
.

On 2025/09/14 16:27, Aleš Horák wrote:

Hi, 

thank you. my patch was the minimum to get it to work, just fixing the 
errors that appeared :-)

yours is more complete and functional 👍

-- 
ales horak


-- 
Aleš Horák


ne 14. 9. 2025 v 5:53 odesílatel Jun Omae <[email protected]> napsal:

Hi,

On Sat, Sep 13, 2025 at 04:13:16AM -0700, Ales Horak wrote:
> current https://trac-hacks.org/wiki/IncludeMacro does not run under Trac 
1.6
> due to genshi imports
> 
> see the attached patch to make it functional
> 
> -- 
> ales horak

Thanks for the patch! However, it seems to be incomplete.

$ pyflakes includemacro/macros.py
includemacro/macros.py:214:59: undefined name 'TracHTMLSanitizer'
includemacro/macros.py:244:23: undefined name 'ParseError'
includemacro/macros.py:255:27: undefined name 'ParseError'
includemacro/macros.py:288:20: undefined name 'ParseError'

Could you please try the attached patch?

-- 
You received this message because you are subscribed to a topic in the 
Google Groups "Trac Users" group.
To unsubscribe from this topic, visit 
https://groups.google.com/d/topic/trac-users/oIX9bq6TkVc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to 
[email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/trac-users/aMY8Eia7Pi0d/sOV%40localhost.

-- 

You received this message because you are subscribed to the Google Groups 
"Trac Users" group.
To unsubscribe from this group and stop receiving emails from it, send an 
email to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/trac-users/CAHm62qP8EwaOVoCpjNiTBThhNNLAs6%2BGGrU6nznXEoX6AOPw7A%40mail.gmail.com
 
<https://groups.google.com/d/msgid/trac-users/CAHm62qP8EwaOVoCpjNiTBThhNNLAs6%2BGGrU6nznXEoX6AOPw7A%40mail.gmail.com?utm_medium=email&utm_source=footer>
.


-- Jun Omae <[email protected]> (大前 潤) 

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/trac-users/99108147-9d89-4159-b467-43257e803ec4n%40googlegroups.com.
--- macros.orig.py	2025-09-27 10:53:09.051770704 +0200
+++ macros.py	2025-09-27 10:55:29.187899320 +0200
@@ -94,7 +94,7 @@
                 return ''
             try:
                 urlf = urlopen(source)
-                out = urlf.read()
+                out = urlf.read().decode('utf-8')
             except URLError as e:
                 return system_message("Error while retrieving file", str(e))
             except TracError as e:

Reply via email to