Scott Geertgens wrote:
In one of my repositories (trac0.9.2+apache2.0.54+mod_python+svn1.2.3), I have a
few folders filled with .PDF files. A recent commit added and modified a number
of them (~20 files affected). When trying to view the changeset through Trac,
Trac is trying to create text diffs for some of them (3-4 files)... at the same
time, the apache process on the server pegs the CPU and things don't seem to
recover without an Apache restart.
I've verified that all the .PDF files all have their mimetype set to
application/octet-stream, and I'm unable to determine a difference between a PDF
that Trac is treating correctly and a PDF that Trac is trying to diff as text. I
will set the mimetype to the more specific application/pdf, but...
Hoping I'm missing something obvious. Thanks!

The changeset module is only using the `is_binary` heuristic in
order to decide if there's something to diff or not.
We should probably first check the mimetype as we do in the
browser module.

Seems like it's worth to fill a ticket for that issue.

-- Christian
_______________________________________________
Trac mailing list
[email protected]
http://lists.edgewall.com/mailman/listinfo/trac

Reply via email to