Anish Shah added the comment: > 1. You lookup from the list of all patches, not necessarily connected with > that particular issue.
Suppose there was an issue1 which was resolved by PR1. Now, this PR1 introduced a new bug - issue2. In this case, we might want to discuss about PR1 in issue2. What do you think? > 2. Don't do lookups at all, but always assume the format we've settled on to > be something you should turn into a link. Additionally, you could think of > adding such link to the list of links. I think, this might not be a good idea. For example, a comment has a string like "PR 23" and we extract the number "23". Now, we need to create the GitHub URL by ourself like - url = "https://github.com/python/cpython/pull"; + pr_no This will fail if in future Github decides to change the URL for pull request. Let me know what do you think? _______________________________________________________ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue587> _______________________________________________________ _______________________________________________ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
