Maciej Szulik added the comment: Anish more comments:
roundup/pull_request.py: > def __init__(self, client): > self.db = client.db > self.request = client.request > self.form = client.form > self.data = json.loads(self.form.value) > self.env = client.env I'd generally suggest loading the json only when you go through the verification. For example, after checking the event in _extract. The other thing, can you make the PR association being done by the user who created a PR (assuming you'll find one based on github name in bpo), otherwise use a environment set "special user" for that. Moreover, have you seen David's comment about creating new issues for the PRs that are being opened but do not mention bpo number, do you think you could add that functionality to this patch? _______________________________________________________ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue589> _______________________________________________________ _______________________________________________ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
