Ezio Melotti added the comment:

I've looked at the latest patch (2016-07-21.16:13:52) and the only major issue 
I've found so far is that any user can unlink (remove) any PR, even the ones 
created by other users.  This is likely because of wrong permissions in 
schema.py.

There are also a few minor low-priority issues and feature requests that can be 
addressed later:
1) it's possible to add the same PR multiple times to the same issue (I also 
tested with http/https).
2) it would be good to support the username/repo#pr_num syntax, perhaps even 
just the PR number and default on the CPython repo;
3) I would prefer the "remove" button to be on the pull_request page.  This 
will make it consistent with the files (they have an "unlink" button), avoid 
unnecessary clutter, and prevent accidental removal of linked PRs;
4) all the i18n:translate="" can be removed;
5) the "Author" column might be misleading, since it refers to whoever linked 
the PR, not the author of the PR.

----------
nosy: +ezio.melotti

_______________________________________________________
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue586>
_______________________________________________________
_______________________________________________
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/

Reply via email to