Ezio Melotti added the comment:
> I've changed it to set_roundup_user, not sure what kind of constant you were
> talking about.
I meant a constant for the python-dev user you find with: user_ids =
self.db.user.filter(None, {'username': 'python-dev'})
Since the python-dev user is not going to change at run-time, there should be
no reason to look it up every time, however it might be difficult to get access
to the db, so if it's too much trouble don't worry about it.
I think the COMMENT_TEMPLATE.format(...) in handle_action() can be further
improved. If you use unicode for the template string, and pass unicode to
format, you should be able to just encode the result once at end (either after
the format or in self.db.msg.create(), assuming create() doesn't accept
unicode).
The rest of the patch LGTM.
_______________________________________________________
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue611>
_______________________________________________________
_______________________________________________
Tracker-discuss mailing list
Tracker-discuss@python.org
https://mail.python.org/mailman/listinfo/tracker-discuss
Code of Conduct: https://www.python.org/psf/codeofconduct/
