On 10/13/06, Laurent Aguerreche <[EMAIL PROTECTED]> wrote:
> Le jeudi 12 octobre 2006 à 17:19 -0400, Edward Duffy a écrit :
> > Lookin' great! Got a couple of patches for you
> >
> > 1. tracker-search-tool won't autogen.sh...EXTRA_DIST acceesses
> > variables that are commented out.
> >
> > 2. The new mp3 extractor creashes tracker-extract (strlen'ing a NULL?).
>
> I would prefer to avoid calls to strlen() on all strings. We only need
> to know when a string is empty, so just:
>
> char *s;
>
> s = foo();
> if (s && s[0] != '\0') {
> ...
> }
>
>
> > 3. mplayer based extractor for videos and audio.
>
> A dependency to mplayer is not acceptable IMHO. On some distribution of
> linux, I wonder whether it will be shipped one day!
> Debian still has problem with some legal things in it...
>
It's not a hard dependancy though ... if its there its used, if not it
keeps going. mplayer just works better for me.
> Is it possible to use GStreamer directly for instance?
>
Probably, I've rarely had any luck with gst-based totem and usually
stick with mplayer. More so with my AMD64, I've got a 32-bit version
of mplayer installed so I can still use the win32 libs.
I'll look at gstreamer as a fallback if mplayer isn't available.
>
>
> Laurent.
>
> > _______________________________________________
> > tracker-list mailing list
> > [email protected]
> > http://mail.gnome.org/mailman/listinfo/tracker-list
>
_______________________________________________
tracker-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/tracker-list
