Edward Duffy wrote: > a few snags: >> >> 1) do a svn update - bits of quite old code are in your patch > damn.. 20 revisions off. >> >> 2) I dont like the fact that we are parsing desktop files and checking >> gconf every time the thumbnailer is called. >> > me neither...I was hoping to find some serialization mechanism in > glib, but no such luck. > >> We need to be smarter than that - perhaps stick a GHashTable for >> mime->thumbnailer in the tracker struct (tracker-utils.h) and load all >> the thumbs/mime at trackerd startup rather than each time we index a >> file. That way we can quickly get at the thumbnailer for a mime while >> indexing. >> > not sure how that would get to tracker-thumbnailer. (?)
as extra param(s)? - pass the fields across for the HashTable, create a struct in tracker-utils.h for the fields you need > >> 3) tracker-thumbnailer should set an alarm for the thumbnailer it spawns >> (just in case of reap failure). > this ones been bugging me! I thought for sure if program A calls > program B which calls program C, and program B dies, program C should > die too! not always - an app might not respond to sigterm or the reaping fails creating a zombie process > Guess I'm going to just have to bite the bullet and explicitly set > alarams everywhere. Im not sure whether alarms do a sigkill or just a sigterm when not handled by default. We really need the kill to be absolutely sure (apps can ignore or not respond to sigterm but they cant with sigkill) -- Mr Jamie McCracken http://jamiemcc.livejournal.com/ _______________________________________________ tracker-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/tracker-list
