Le dimanche 22 juillet 2007 à 23:26 +0100, jamie a écrit : > On Mon, 2007-07-23 at 00:16 +0200, Laurent Aguerreche wrote: > > Le lundi 23 juillet 2007 à 00:13 +0200, Laurent Aguerreche a écrit : > > > Le dimanche 22 juillet 2007 à 22:33 +0100, jamie a écrit : > > > > On Sun, 2007-07-22 at 23:21 +0200, Laurent Aguerreche wrote: > > > > > Hello, > > > > > > > > > > a patch to fix a potential crasher in tracker_set_language() function > > > > > : > > > > > > > > > > - g_free() was called whether pointer to free could be NULL; > > > > > - we were mixing allocated strings and on-stack strings; > > > > > - added tracker_get_english_lang_code() function and put back tmap > > > > > implementation in tracker-utils.c (avoid warnings at building time) > > > > > > > > > > + cosmetic changes : I removed some empty lines for instance. > > > > > > > > > > > > > > > Can I commit? > > > > > > > > > > > > > > > > > > ok for this one but no more cleanups pls until post 0.6 as I want to > > > > release tomorrow > > > > > > > > (I would prefer bugfixes to be separate from wide ranging cleanups if > > > > possible) > > > > > > Ok. > > > > > > > > > About Gaim: it recently changed its name in favour of Pidgin. Gaim uses > > > library Purple as a network layer. This library is also responsible for > > > chat logging. > > > > Sorry, it is Pidgin which uses Purple. > > > > > > > For people who used Gaim (like me), "logs" directory in "~/.gaim/logs" > > > became a symbolic link to "~/.purple/logs". > > > Since trackerd do not follow links, it does not see "logs" link as a > > > correct directory and do not index anything from this directory. > > > Furthermore, we need to index Purple chat logs (not Pigin directly > > > because Purple may be used by others programs). > > > > > > How to fix that? Will we delay that for post Tracker 0.6? > > > I quickly added ~/.purple/logs as a gaim conversation directory > > I need someone to test its picking then up though
My Purple logs seem to be indexed... On another side, I took a look at tracker-preferences.c and saw a code with a really bad complexity, so a little patch. I hope that such a code is not anywhere else! > jamie > >
Index: src/tracker-preferences/tracker-preferences.c
===================================================================
--- src/tracker-preferences/tracker-preferences.c (révision 702)
+++ src/tracker-preferences/tracker-preferences.c (copie de travail)
@@ -680,23 +680,20 @@
static void
populate_list (GtkWidget * treeview, GSList * list)
{
- guint index = 0;
- GtkTreeIter iter;
- gchar *data = NULL;
- GtkTreeModel *store = NULL;
+ GtkTreeModel *store;
+ GSList *tmp;
store = gtk_tree_view_get_model (GTK_TREE_VIEW (treeview));
- for (; index < g_slist_length (list); ++index) {
- data = g_slist_nth_data (list, index);
+ for (tmp = list; tmp; tmp = tmp->next) {
+ if (tmp->data) {
+ GtkTreeIter iter;
+ gchar *data = tmp->data;
- if (!data)
- continue;
-
- gtk_list_store_append (GTK_LIST_STORE (store), &iter);
- gtk_list_store_set (GTK_LIST_STORE (store), &iter, 0, data,
- -1);
- }
+ gtk_list_store_append (GTK_LIST_STORE (store), &iter);
+ gtk_list_store_set (GTK_LIST_STORE (store), &iter, 0, data, -1);
+ }
+ }
}
GType
signature.asc
Description: Ceci est une partie de message numériquement signée
_______________________________________________ tracker-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/tracker-list
