On Tue, 2008-01-22 at 20:34 +0800, Halton Huo wrote: > Jamie and All, > > The patch for explicit apply is ready for review. > > Summary: > [1] Functions throttle_changed_cb() spin_value_changed_cb() and > check_toggled_cb() are removed since they are for instant apply. And the > also the signal connect calls are removed. > > [2] Rename action button "Close" to "Apply", add buttons "Cancel" and > "OK" in glade file. > > [3] Rename tracker_preferences_cmd_close() to > tracker_preferences_cmd_apply() to do save configuration and send > changes. Only send change when the value of key are different with > before one. > > [5] Add funtion str_slist_equal() to check changes for list key > like /Watches/WatchDirectoryRoots, /Watches/CrawlDirectory, > /Watches/NoWatchDirectory and /Indexing/NoIndexFileTypes. > > [4] Add function tracker_preferences_cmd_cancle() > and tracker_preferences_cmd_ok() >
everything looks ok but can you *NOT* reindex on following: 1) chkSkipMountPoints 2) WatchDirectoryRoots 3) CrawlDirectoryRoots 4) NoWatchDirectoryRoots (we already handle this at startup in trackerd.c) 5) NoIndexFileTypes see code in trackerd.c for how we remove entries in ignored paths - i would like to use that for above instead of forcing a reindex. As it will probably need sql to do i shall do that bit (unless you feel up to it?) For now remove the reindex for the above options and then apply to svn thanks jamie _______________________________________________ tracker-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/tracker-list
