On Jan 30, 2008 8:05 AM, Michael Biebl <[EMAIL PROTECTED]> wrote:
> 2008/1/29, Jamie McCracken <[EMAIL PROTECTED]>:
> >
> > On Tue, 2008-01-29 at 21:26 +0100, Luca Ferretti wrote:
> > > Here is a patch to make reindex/restart alerts in tracker-prefs HIG
> > > compliant.
> > >
> > > Please check if secondary message is right...
> >
> >
> > its fine - pls apply
> >
>
> I'm not a native speaker, but some of the text doesn't sound correct to me.
> E.g: In order your changes will take effect (In order for your changes
> to take effect)
> Tracker have to reindex them (tracker has to reindex them)
> action will be performed the next time Tracker daemon will be restarted
> (action will be performed the next time Tracker daemon is restarted)
>
> Any native speaker around to check that?
>
> Michael
I agree, the English is off a bit. Attached is a quick revision of the patch.
Could probably remove the "click restart to restart the daemon now" line, as
it should be fairly obvious from the button labeled "Restart" (in my
opinion at least),
but the included patch leaves it there just to make it more clear.
> --
> Why is it that all of the instruments seeking intelligent life in the
> universe are pointed away from Earth?
>
> _______________________________________________
> tracker-list mailing list
> [email protected]
> http://mail.gnome.org/mailman/listinfo/tracker-list
>
Index: src/tracker-preferences/tracker-preferences.c
===================================================================
--- src/tracker-preferences/tracker-preferences.c (revisione 1107)
+++ src/tracker-preferences/tracker-preferences.c (copia locale)
@@ -891,19 +891,49 @@
if (flag_restart && if_trackerd_start (priv)) {
GtkWidget *dialog;
- char *msg;
+ gchar *primary;
+ gchar *secondary;
+ gchar *button;
if (flag_reindex) {
- msg = _("Your system must be re-indexed for your changes to take effect. Re-index now?");
+ primary = g_strdup (_("Data must be reindexed"));
+ secondary = g_strdup (_("In order for your changes to "
+ "take effect, Tracker must reindex your
+ "files. Click the reindex button to "
+ "start reindexing now, otherwise this "
+ "action will be performed the "
+ "next time the Tracker daemon "
+ "is restarted."));
+ button = g_strdup (_("_Reindex"));
+
} else {
- msg = _("Tracker indexer needs to be restarted for your changes to take effect. Restart now?");
+ primary = g_strdup (_("Tracker daemon must be "
+ "restarted"));
+ secondary = g_strdup (_("In order for your changes to "
+ "take effect, the Tracker daemon "
+ "has to be restarted. Click "
+ "restart to restart the "
+ "daemon now."));
+ button = g_strdup (_("_Restart"));
}
dialog = gtk_message_dialog_new (GTK_WINDOW (main_window),
GTK_DIALOG_MODAL,
- GTK_MESSAGE_QUESTION,
- GTK_BUTTONS_YES_NO,
- msg);
+ GTK_MESSAGE_WARNING,
+ GTK_BUTTONS_NONE,
+ primary);
+
+ gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
+ secondary);
+
+ gtk_dialog_add_buttons (GTK_DIALOG (dialog),
+ GTK_STOCK_CANCEL, GTK_RESPONSE_NO,
+ button, GTK_RESPONSE_YES, NULL);
+
+ g_free (primary);
+ g_free (secondary);
+ g_free (button);
gtk_window_set_title (GTK_WINDOW (dialog), "");
gtk_container_set_border_width (GTK_CONTAINER (dialog), 5);
_______________________________________________
tracker-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/tracker-list
