Philip Van Hoof wrote:
On Wed, 2009-02-11 at 15:09 +0100, Carlos Garnacho wrote:
Overall, great patch :), makes things quite more generic. A few comments
about it:
* What about using GTypeModule and GInterfaces for the modules? you
could have a single module that implements one interface for the indexer
and other interface for trackerd.
I tried this, I found it too complicated and more difficult for higher
languages to integrate with. For example this way it's relatively easy
to write a push module in Vala.
There were also a few things that were not possible, or quite difficult
at least. I had started the refactor to make them similar to how your
module-sys works. But that was not possible for a couple of reasons.
I decided to just use GModule (it's only about a few methods anyway).
I have to say, I agree with Carlos here. Perhaps Jurg can provide some
information about if this is really not possible in Vala.
Pausing, pre-committing and continuing it something I think will
eventually be necessary to add (for example a AddMany that adds really a
lot of triples, should pause+pre-commit, import, and then continue the
indexer.
Kinda like freeze/thaw.
I might be talking about something I don't quite understand here, but no
one except the daemon should be pausing/continuing the indexer (other
than itself right now which we decided would change later). The
tracker-status module in trackerd is responsible for signalling and
controlling all of this.
--
Regards,
Martyn
_______________________________________________
tracker-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/tracker-list
