On 18/11/09 21:19, Debarshi Ray wrote:
As advised by Philip (on IRC), I created a separate branch locally and
replaced the broken Nautilus extension written in Python using my
code.
Hi Debarshi,
I have reviewed the code quickly and I have some comments to make. I am
currently on vacation in China, so when I get back (Monday next week), I
would like to reply to you with a proper review.
Thanks for doing this work. Great to see this sort of thing being done!
There are some known memory leaks and I do not know how to fix them.
I can probably help you with those next week.
I
need to pass two custom values to the callbacks for the menu items.
eg., a GtkWindow * and a TrackerTagsPlugin *. So I g_new0 an array of
void *, put each value into each element of the array and pass the
array to the callback. Now I can not g_free the array within the
callback because subsequent invocations of the callback will crash.
How do I do it then?
Usually you would have to keep a static GList* or GHashTable around with
these values. Also, if you are creating many items of the same structure
size, I recommend you use g_slice_new0() not g_new0().
Again, I can assist you next week, if the rest of the team haven't
already helped you out here.
--
Regards,
Martyn
_______________________________________________
tracker-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/tracker-list
