On Fri, 2009-11-20 at 15:47 +0100, Juan A. Suarez Romero wrote: > On Fri, 2009-11-20 at 15:20 +0100, Philip Van Hoof wrote: > > One immediate big remark with the patches is that you are silently > > trying to lower the version requirements for sqlite. > > > > Don't > > Yes, I did it because in Fremantle, sqlite is 3.6.14.
Not good. If Fremantle's sqlite is not recent enough then you'll need to upgrade sqlite on Fremantle. > There's a comment in code telling that 3.6.16 is required for the tests. > Well, it wasn't my intention to run those tests in Fremantle. I think a unit-test failed with 3.6.14 and didn't fail with 3.6.16 indicating a bug in sqlite 3.6.14 that affects us. > Also, I've checked that all was working fine, either building and > running, when I've downgraded that requirement. > > Obviously, other solution is to upgrade sqlite in Fremantle to 3.6.16. > But I didn't try. This is the obvious solution that you need to aim for, yes. > > I guess the renaming of these files is a team decision that I can't make > > on my own, so I can't push these patches right now. > > > > We'll discuss this, though. > > > > > Are you talking about *all* tools, or just those that were renamed in > the patch? > > In the first case, I strongly agree with you that is your decision to do > it. I've just added the comment because Ivan suggested it. > > If you are talking about the files renamed in the patch, well, there is > no choice if you want to have both trackers in Fremantle. And the aim of > the patches is to allow Tracker 0.7 running in Fremantle, without > interfering with applications using Tracker 0.6. > > J.A. > > > > -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be _______________________________________________ tracker-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/tracker-list
