Hi,

commit 02d1683929bf543a90bb73060283f7a1a4b5e2ef introduced a
regression wrt portability.

tracker does no longer compile on e.g. kfreebsd [1].
I pushed a fix for 0.6 at [2], although I'm not sure if you're still
interested in the 0.6 branch, so this is just for completeness sake.
For 0.8 a proposed patch is attached.

Please review.

Cheers,
Michael


[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=576938
[2] 
http://git.debian.org/?p=users/biebl/tracker.git;a=commitdiff;h=61f000a1e5f801c248fea4140b58604cba981fa0

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
From a6539f5cabee4459140e573c6e1fb60fe73fa852 Mon Sep 17 00:00:00 2001
From: Michael Biebl <[email protected]>
Date: Thu, 8 Apr 2010 20:00:16 +0200
Subject: [PATCH] Don't build VFAT check on non-linux platforms.

---
 src/miners/fs/tracker-miner-files.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/miners/fs/tracker-miner-files.c b/src/miners/fs/tracker-miner-files.c
index 621895b..5e55576 100644
--- a/src/miners/fs/tracker-miner-files.c
+++ b/src/miners/fs/tracker-miner-files.c
@@ -21,8 +21,10 @@
 
 #include <sys/statvfs.h>
 #include <fcntl.h>
+#ifdef __linux__
 #include <sys/ioctl.h>
 #include <linux/msdos_fs.h>
+#endif /* __linux__ */
 #include <unistd.h>
 
 #include <glib/gi18n.h>
@@ -1777,6 +1779,7 @@ tracker_miner_files_check_directory (GFile  *file,
 	 */
 	is_hidden = file_info && g_file_info_get_is_hidden (file_info);
 
+#ifdef __linux__
 	/* Second we check if the file is on FAT and if the hidden
 	 * attribute is set. GIO does this but ONLY on a Windows OS,
 	 * not for Windows files under a Linux OS, so we have to check
@@ -1796,6 +1799,7 @@ tracker_miner_files_check_directory (GFile  *file,
 			close (fd);
 		}
 	}
+#endif /* __linux__ */
 
 	if (is_hidden) {
 		/* FIXME: We need to check if the file is actually a
-- 
1.7.0.4

_______________________________________________
tracker-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/tracker-list

Reply via email to