On Fri, 2012-12-14 at 13:56 +0000, Martyn Russell wrote: > On 14/12/12 13:52, Philip Van Hoof wrote: > > On Fri, 2012-12-14 at 08:39 +0000, Martyn Russell wrote: > > > >> * tracker-0.10.37-fix-linking-with-newer-toolchain.patch > >> * tracker-0.10.37-fix-linking-with-newer-glib.patch > >> > >> These two shouldn't be needed - looks like a fix added to circumvent > >> breaks elsewhere. Not something we should be applying upstream AFAICS. > > > > Yes I agree, adding manual -lgio-2.0 and -lgthread-2.0 is just wrong. > > > >> * tracker-0.10.37-add-userguides-service-for-maemo.patch > >> > >> This seems unnecessary with >= 0.14. > > > > Ok. That's strange because they are using 0.14.2. > > Actually, they should stay clear of 0.14.2 and use 0.14.4, there are > some nasty issues fixed between those versions.
I'll tell them, or feel free to ping Aard on #jollamobile - freenode. > If they are using 0.14 why is the patch mentioning 0.10 - I guess > they're just using the patch because it was there before. They should be > able to remove that. Yeah, probably. > >> * 0005-Fix-missing-gobject-introspection-checks.patch > >> > >> This is to disable introspection. So not what we want upstream. There > >> is a --disable-introspection switch already for configure. Perhaps > >> this wasn't around a while ago? > > > > I'll communicate this to them when I speak them again. > > I could be wrong, but this uses automake macros I think and they didn't > have that macro set up on their systems before at Nokia. It's quite > stupid to require a macro to disable the thing the macro is installed as > part of, but that's how gtkdoc and the introspection foo work. This > might be why this is still needed. Hrmm, somebody should finally fix this in gtkdoc and (its) autofoo. For how many years has this been bugging people? yes..years. meh > >> * 0003-tracker-0.9.26-create-tests-aegis.patch > >> > >> This is really not for the public version of Tracker I would say. > > > > I even wonder whether Jolla ships with Aegis ... > > I would dump it entirely, it caused no end of disruption and problems > for developers and users throughout. > > But it's not my platform :) I agree, and I agree that it's also not my platform :). > >> * 0002-Tracker-extract-Parse-the-video-filename-to-obtain-e.patch > >> > >> Reviewed, but needs resolution as Aleksander says. Still applies too. > > > > Ok check. > > > >> * 0001-Tracker-0.7.23-desktop-files.patch > >> > >> Pushed. > > > > Thanks awesome. > > No problem :) Cheers, which reminds me: are you going to fosdem Martyn? :) Philip -- Philip Van Hoof Software developer Codeminded BVBA - http://codeminded.be _______________________________________________ tracker-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/tracker-list
