-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I'll review in my slack time. So I'll do this chunk per chunk. Let's
start with the first few commits ;-)
e5b5280b5f336b80b00d9c9671a72391ab1f0a9b
+ data->dbus_path = g_strdup_printf ("/%s", dbus_name);
+
+ p = data->dbus_path;
+ while ((p = strchr (p, '.')) != NULL) {
+ *p++ = '/';
+ }
+
+ data->dbus_name = l->data;
D-Bus service names and D-Bus paths shouldn't be correlated like this.
It should be possible to have a different D-Bus service name than the
object's path. Translating the name to a path by search and replacing
. with / doesn't sound right to me.
f985f643b849a61fe7a10a3fd9c4f7f4a8083b13
In finalize:
+ if (priv->roots_to_notify) {
+ g_hash_table_unref (priv->roots_to_notify);
+ }
vs.
notify_roots_finished:
+ if (check_queues && g_hash_table_size (fs->priv->roots_to_notify) < 2) {
So if you check priv->roots_to_notify for not being NULL in finalize,
then isn't it possible that in notify_roots_finished the same member
can also be NULL? Or is notify_roots_finished always disconnected in a
timely matter?
c2863b39b4e8f178c4d87ceee5d96ad0c3647585
if (fs->priv->item_queue_blocker) {
trace_eq (" cancelled: item queue blocked waiting for file
'%s'",
- - g_file_get_path (fs->priv->item_queue_blocker));
+ g_file_get_uri (fs->priv->item_queue_blocker));
return;
" a string containing the GFile's URI. The returned string should be
freed with g_free() when no longer needed."
Afaik this was and is in both cases a memory leak. You need to
g_free() the result of g_file_get_uri. You probably just search and
replaced here, but it found a leak ;-)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (MingW32)
iQEcBAEBAgAGBQJT5IMOAAoJEEP2NSGEz4aDkQsH/1jVzyV1dJTIrBoUAuyckaXN
m7lKH5sp6lJ515MxfmHnJhTppd57uXkCPrWumy5qthP/qzvHecGxOoUcv+xf0i36
dvh3LAb4eogSCUygG4MDZi6iW70DEzLeVT6/HwiHkW3KcJYmjp0+wELVn6dTZQn7
f5EXHJMP56vj5ATPPziaP2qWt9w+8bMbOCm4WtfL44QoAQbEaah0LwwYUdR/8gjA
SHIAtcyqmFHZtA/q3EHYyaOWG00Md0UKCV5kowutne62AFW93TG8ds91KzEsOqCP
8a3lFIaSF2OBEQKgpKtlej+KwBgVBG2nRag09L/OAOxtC2gLiVsgz0eu5Is99o8=
=394z
-----END PGP SIGNATURE-----
_______________________________________________
tracker-list mailing list
tracker-list@gnome.org
https://mail.gnome.org/mailman/listinfo/tracker-list
