It looks like the first one is due to some Timezone mangling (fun!) in ApplicationController#create_todo_from_recurring_todo. I think we need to get a solid fix on this Date+timezone issue (as per previous discussion) now that Rails has timezone support. I will see if I can create a simple test to prove that Dates have no timezone support.
On Sep 10, 2008, at 9:05 AM, Eric Allen wrote: > I'm getting two failing tests on bsag/tracks/master. Is something > wrong with my configuration? > > 1) Error: > test_new_recurring_todo(RecurringTodosControllerTest): > ArgumentError: comparison of Date with Time failed > /Users/epall/programming/tracks/app/models/recurring_todo.rb: > 612:in `>' > /Users/epall/programming/tracks/app/models/recurring_todo.rb: > 612:in `determine_start' > /Users/epall/programming/tracks/app/models/recurring_todo.rb: > 521:in `get_yearly_date' > /Users/epall/programming/tracks/app/models/recurring_todo.rb: > 385:in `get_next_date' > /Users/epall/programming/tracks/app/models/recurring_todo.rb: > 355:in `get_due_date' > /Users/epall/programming/tracks/app/models/recurring_todo.rb: > 561:in `has_next_todo' > /Users/epall/programming/tracks/app/controllers/application.rb: > 190:in `create_todo_from_recurring_todo' > /Users/epall/programming/tracks/app/controllers/ > recurring_todos_controller.rb:113:in `create' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/base.rb:1162:in `send' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/base.rb:1162:in `perform_action_without_filters' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/filters.rb:580:in `call_filters' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/filters.rb:573:in `perform_action_without_benchmark' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/benchmarking.rb:68:in > `perform_action_without_rescue' > /opt/local/lib/ruby/1.8/benchmark.rb:293:in `measure' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/benchmarking.rb:68:in > `perform_action_without_rescue' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/rescue.rb:201:in `perform_action_without_caching' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/caching/sql_cache.rb:13:in `perform_action' > /Users/epall/programming/tracks/vendor/rails/activerecord/lib/ > active_record/connection_adapters/abstract/query_cache.rb:33:in > `cache' > /Users/epall/programming/tracks/vendor/rails/activerecord/lib/ > active_record/query_cache.rb:8:in `cache' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/caching/sql_cache.rb:12:in `perform_action' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/base.rb:529:in `send' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/base.rb:529:in `process_without_filters' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/filters.rb:569:in > `process_without_session_management_support' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/session_management.rb:130:in `process_without_test' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/test_process.rb:16:in `process' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/test_process.rb:394:in `process' > /Users/epall/programming/tracks/vendor/rails/actionpack/lib/ > action_controller/test_process.rb:365:in `put' > ./test/functional/recurring_todos_controller_test.rb:32:in > `test_new_recurring_todo' > /Users/epall/programming/tracks/vendor/rails/activerecord/ > lib/../../activesupport/lib/active_support/testing/ > setup_and_teardown.rb:67:in `__send__' > /Users/epall/programming/tracks/vendor/rails/activerecord/ > lib/../../activesupport/lib/active_support/testing/ > setup_and_teardown.rb:67:in `run' > > 2) Failure: > test_toggle_check_on_recurring_todo(TodosControllerTest) > [./test/functional/todos_controller_test.rb:378:in > `test_toggle_check_on_recurring_todo' > /Users/epall/programming/tracks/vendor/rails/activerecord/ > lib/../../activesupport/lib/active_support/testing/ > setup_and_teardown.rb:67:in `__send__' > /Users/epall/programming/tracks/vendor/rails/activerecord/ > lib/../../activesupport/lib/active_support/testing/ > setup_and_teardown.rb:67:in `run']: > <"Call Bill Gates every day"> expected but was > <"Call Bill Gates to find out how much he makes per day">. > > <fail_output.txt> _______________________________________________ Tracks-discuss mailing list [email protected] http://lists.rousette.org.uk/mailman/listinfo/tracks-discuss
