Hi,
After dropping {import,export}_net modules, we still have some pieces of
code implementing network stream functionalities.
I think we have a couple of issues with this situation:
1) It's anybody out there that just uses such functionalities? :)
I guess isn't, otherwise somebody has claimed modules at time, but one
never knows ;)
2) Without {import,export}_net, existing functionalities are mutilated or just
broken. Let me expand a bit.
Let's see (today's CVS) src/transcode.c lines 3848/3851.
We start server thread (defined in src/info_server.c) if and only if user
selected export_net for audio and/or for video export. Of course having
dropped such modules this is just impossible.
So src/info_server.c and stuff is in facts dead code... And
if info_server is never started, the whole net support into tccat/tcprobe
become useless. Let's take a look at import/probe_socket.c: we have here
the only code that connects to info_server (grep -R TC_DEFAULT_PPORT agrees
with this last statement), but we already known that info_server will never
startup...
So, to summarize, we have a simple choice:
1) restore {import,export}_net modules
2) drop remaining bits of NET_STREAM support.
My vote goes to choice #2. If noone objects, I'll go ahead in a few days
(3-4, I'm working on new output rotation code and on other real-life stuff).
As usual, any comment is appreciated.
Best regards,
--
Francesco Romani - Ikitt ['people always complain, no matther what you do']
IM contact: (email-me, I have antispam default deny!) icq://27-83-87-867
some known bugs: http://www.transcoding.org/cgi-bin/transcode?Bug_Showcase
