It's nice to get an evening to work on transcode every one in a
while ;)
Definitively ;)
I've written and committed (to CVS HEAD) a new command line parser
for transcode.
Nice! Option handling was one of heaviest sections on our Big Beast (src/transcode.c)
before. New code looks defintively lighter and better :)
Since we're talking about src/* content, feel free to comment/blame me about new framebuffer
code recently committed by myself.
The overall parsing routine and its helper functions are in
src/cmdline.[ch]. I've also taken a bunch of variables used in option
handling that used to be main() local and dropped them in cmdline.c as
global variables until something better is found to be done with them.
Maybe split configuration values (the hard part is to properly identify them)
from stream properties in vob_t can be a feasible way?
Anyway, unless someone brave enough take care of this, it's definitively
a far future job for me.
* The undocumented long option names for most of the short options have
changed, e.g. -i is now --input instead of --input_file.
We really need long option name aliases for each short option?
I've nothing against those, I just wonder if this (in general sense)
is an overkill or not.
* -u buffers,threads is now deprecated (-u buffers is fine; use
--threads to specify the number of threads).
Fine!
* --keep_asr is now disabled, as the code implementing it is broken (it
doesn't interact properly with other options). If you need to keep
the same aspect ratio, calculate the appropriate values manually.
Maybe that should be reintroduced for 1.1.0? I'll take a look later to
figure out what's wrong (I've a very few clues right now :) ).
* --color is now gone entirely, because it didn't actually do anything.
IIRC the purpose was to avoid that ANSI terminal color sequences screw output
if stdout was not-term (file...).
I've nothing about --color removal, anyway.
Francesco Romani
