On 12/5/06, Scott Smith <[EMAIL PROTECTED]> wrote:
On 12/4/06, Andrew Church <[EMAIL PROTECTED]> wrote: > Personally, I've had my eye on getting rid of import_exit() > entirely,
I fully agree with this.
well a little more digging shows that apparently fwrite is not the preferred method. Most other modules use p_write, which in turn calls xio_write, which in turn either calls write or a handler specific for that descriptor.
That makes think that we're talking about 1.0.x branch, am I right? While patches are always welcome, I strongly encourage you to provide patches against CVS HEAD branch. That of cours DOES NOT mean that patches against old branch will be rejected! Patches against new development branch are just preferred :) Also p_write is interrupt safe, though I think
fwrite provides that same protection.
I don't remember what standard(s) say about that. The only other thing fwrite
does is give you buffered output, but I don't think that is very important for the decoders (which are already outputting more than they are inputting!).
Agreed. Also, all the callers of p_write check the return value. I'll send
out a patch that converts the fwrite's to p_write's, to bring those modules up to date.
Sounds nice. Thanks for collaboration. Bests, -- Francesco Romani
