On Sun, 2007-07-29 at 00:32 +0200, Branko Kokanovic wrote: > hi again, > > I tried to change some of existing filters to NMS, and filter_invert > looked easy, so I started and 2h after, here's this patch.
Looks good, committed to HEAD with minor changes (mostly STYLEish). > I tried to fix all those things I didn't do in filter_mirror - again, > take a deep look and see if it's OK. No line was deleted (theoretically yes), > only rearranged and fixed one warning, and all those nitpickings Francesco > pointed out were (I hope so) changed from original. No obvious faults emerged, basic testing in progress :) > I could change some other filter modules too, if time allows me and if > it's OK with you:/ That would be WARMLY welcome, if you like to do so. > P.S. there is one thing I didn't get it, and no NMS module uses it so > I didn't have a reference, - that thing is marked as TODO in file, so > take a look I've seen. Our introspection machinery is still uncomfortable, maybe this will change again in 1.2.0 cycle, I don't know. I'll add some lines on this topic on documentation when in beta stage. Thanks for your contributions! :) Bests, -- Francesco Romani // Ikitt
