On Sat, 2007-12-15 at 03:47 +0000, Andrew Church wrote: > >Hello. > > > >When building transcode for Fedora devel I noticed that there is some > >confusion with asm-types in import/nuv/RTjpegN.h It seems it tries to > >define some types that really should come from asm/types.h and the > >include guard used is all wrong, especially on x86_64... The attached > >patch fixes the compilation issue and applies to the HEAD branch as > >well. > [...] > >+#include <asm/types.h> > > Unfortunately, I doubt this will work very well on non-Linux platforms;
I'm as well worried about the portability of this solution. > the proper solution(*) is to #include <stdint.h> and use uint8_t and > friends. Francesco, I have a vague recollection that you had a patch > along those lines in the works; is that the case? If not, I'll see what > I can put together. Well, assuming (I will be optimist once in lifetime) that a brutal s/__u8/uint8_t/g (etc. etc.) will not break anything, I can setup a patch doing like that in ~zero time. I had started something on this line a few weeks ago, but I eventually dropped that. I have mixed feelings about this solution (I see no reason [yet] why this should break anything at least on x86, but I'd like to do some automated testing, that unfortunately is lacking), but I'm tempted to apply. I'll reply again proposing a (trivial) patch in a few hours. > (*) The _proper_ solution would be to get rid of it entirely and link it > in from an external library, but I seem to recall failing to find > such a library last time I looked... Of course I fully agree. -- Francesco Romani // Ikitt [ Out of memory. ~ We wish to hold the whole sky, ~ But we never will. ]
