On Fri, Jan 11, 2008 at 08:52:10AM +0100, Francesco Romani wrote: > > On Fri, 2008-01-11 at 03:23 +0000, Tom Shield wrote: > > Hello, > > > > I had to add $PTHREADS_LIBS to the following line in configure: > > > > LIBMPEG3_EXTRA_LIBS="$LIBMPEG3_EXTRA_LIBS $PTHREAD_LIBS $($PKG_CONFIG > > --libs libmpeg3)" > > That's interesting (and unexpected). I'll add this to configure if > someone else claims that is needed.
seems to me, that the problem is with libmpeg3's pkg-config data. if it is necessary to link with $PTHREAD_LIBS when linking with libmpeg3, then `pkg-config --libs libmpeg3` should contain $PTHREAD_LIBS. I think it's better to fix such problems where the problem originates (libmpeg3) than down the line. but I also don't really see a problem with adding work-arounds down the line, as long as they are reported upstream. Tom, you could also have "LIMPEG3_EXTRA_LIBS=-lpthread" (or "LIMPEG3_EXTRA_LIBS=-pthread" or whatever's most apropriate for your OS) in your environment when running ./configure for transcode instead of patching configure. this functionality, "FOO_EXTRA_LIBS=bar ./configure", was added for exactly such (`pkg-config --libs foo` or `foo-config --libs` being incomplete) issues, as the correctness of pkg-config data varies considerably (more than you might think, anyway) from OS to OS. anyway, $0.02 from my POV. > Best regards and thanks for reporting. > > -- > Francesco Romani // Ikitt > [ Out of memory. ~ We wish to hold the whole sky, ~ But we never will. ] > -- [EMAIL PROTECTED] SDF Public Access UNIX System - http://sdf.lonestar.org
