Hi Francesco, Hi transcode-folks
I guess you thought I gave it up, since I did not reply for half a year, but
this is not the case, I just had absolutely no time.
In the meanwhile I adapted my code to compile with the CVS HEAD.
I have now some questions:
a) how am I supposed to contribute the code. Do I get a CVS login or should I
send patches?
b) Do you have a better name for the plugins?
The stabilization as a whole is a two phase process:
I) detection of relative transformations, which is at the moment
called "stabilize" which is not very fitting.
II) smoothing and application of transformation. This is called "transform"
and can also be used for different purposes. I think that is okay.
c) For the transformation plugin I would like to be able to resize the frames
(one factor for the entire clip), because I do also rotations and there is a
need for interpolations. An increase in frame size would increase the
quality. Is it possible to do that and what is neccessary.Thank's a lot. Georg PS: for those who forgot here is a link to some sample movies: http://public.flexman.homeip.net/vid.stab/features.php On Tuesday 11 March 2008, Francesco Romani wrote: > On Mon, 2008-03-10 at 11:12 +0100, Georg Martius wrote: > > Am Monday, 10. March 2008 schrieb Francesco Romani: > > > At first glance the code looks very nice. :) > > > The main (and only, so far) problem is that code is meant to be > > > integrated with old 1.0.x branch, not newer ones (HEAD/1.1.x). > > > > I can of course adapt it to fit in the HEAD branch. I just had some > > problems with compiling the CVS version. I will try again and let you > > know. > > That's nice! Thanks for doing this :) > I'm a bit concerned about compilation problems, CVS/1.1x should compile > fine and (almost enteraly) warningless using standard configure, so if > isn't your case please feel free to report problems here. > > Also please provide changes against CVS HEAD (even if isn't much > different from 1.1.x) since 1.1.x branch is slowly stabilizing and it > will not accept new code until the long-waited release. > > HEAD/1.1.x is a really different beast with respect to 1.0.x, but > hopefully it is also much more friendly, has comprehensive style guide > and in general it is in much better shape. If you have any doubts or > trouble, please feel free to ask: that's the purpose of -devel :) > For examples of good new-style filters, please see > filter/filter_doublefps and filter/filter_levels (and any else using > TC_FILTER_OLDINTERFACE macro) in HEAD branch. > > A few more thoughts about the code (if you want deeper discussion, just > ask me). > First, I see some code in transform.h; Even If I've done something > similar in recent past (see libtc/tcmodule-plugin.h and friends), I'm > now fully convinced that isn't good practice. Moving such code in a .c > file will be fine; Even better whould be generalize a list > implementation and add it into libtc. If you're interested, I've a few > ideas and I can write down something if you like. > If I Understood Correctly (unliklely, I've see some parts of code really > fast), it is possible that your code changes the frame size on the fly. > Am I correct? > If so, we should really try to avoid it, because this can lead to nasty > results and can raise subtle bugs. > > Sorry for long mail, I hope you'll find it useful, and thanks again for > your contribution. > > Bests, -- ---- Georg Martius, Tel: +49 177 6413311 ----- ------- http://www.flexman.homeip.net ----------
signature.asc
Description: This is a digitally signed message part.
