On Wed, 2008-12-10 at 05:39 +0000, Andrew Church wrote: > - Accept all three, and accept subq values 1-9 instead of the current 1-7. > - For versions <= 64, silently clamp subq to the range 1-7. > - For versions >= 65, report a warning if bidir_me or brdo are used (but > continue processing anyway, ignoring the options). > > Francesco, does this look okay to you? I've gone ahead and committed a > patch to this effect, but feel free to revise. (In particular, I wasn't > sure whether we should warn that those options will be obsolete in later > x264 versions.)
Yes I'm fine with the code. The only thing that makes me think if it's worth keep compatibility with not-current x264 versions. It's hard to make a general statement about that. My gut feeling is that doing like that is fine in branches (e.g. 1.1.x, 1.0.x) not in HEAD. Anyway, I've no problem with this patch and I will keep that way > P.S. Yes, I'm still alive -- I just had an 11-month-long non-maskable > interrupt from work to deal with. (: So nice to read you again :) PS: just for curiosity: what do you think about switching to SVN somewhere into the far future? I mean, I can live with CVS, but I feel much more comfortable with SVN. No big things, but a lot of little annoyance fixed. Bests, -- Francesco Romani // Ikitt http://fromani.exit1.org ::: transcode homepage http://tcforge.berlios.de ::: transcode experimental forge
