Hi Francesco, On Sunday 23 October 2011, Francesco Romani wrote: > On 10/22/2011 10:41 PM, Georg Martius wrote: > > Hi Francesco, > > > > thanks for appliing the patches. > > > > On Thursday 20 October 2011, you wrote: > >> On 10/01/2011 10:36 AM, Francesco Romani wrote: > >> .... > >> All patches I found are been applied. The is the repo: > >> > >> https://bitbucket.org/france/transcode-tcforge > >> > >> Things missing before the tag (and thus the release) > >> > >> - a bit of testing from mine > >> - a fix for a stabilizer bug reported privately from me > > > > Can you tell me about the bug? Otherwise I just wait for you patch, which > > is also fine. > > Of course. Here follows the (rough) translation of the original bug report: > > """ > [By analyzing the output I noticed the pixel border not suitable for > stabilization are not equal to the preceding frame as should be and is > claimed in the description of the "crop" flag. > [...] > In the filter_transform.c file, [...] transform_filter_video() > pre-initializes the output stabilized frame using the input file. > [...] > The pre-initialization sets a value for the border pixel that possibly > aren't modified during the roto-translation transformations needed by > the stabilization. > [...] > And this is the error, the output should be initialized using the > ***previous*** output frame instead of > the input frame, which is not stabilized! > """ Great, this is indeed a good idea. It is not ideal, but so simple that we should go for it. An ideal solution would use the past frames and transform them be the average camera speed. One problem is, that again black borders can appear (that is why one has to use multiple frames and a larger virtual frame buffer). Anyhow, this is very complicated and not very useful.
Another question: Is transcode using openmp? Because I would really like to parallelize the filter code, which is very simple with openmp. If yes, that I would maybe even do it before the release. Regards, Georg -- ---- Georg Martius, Tel: +49 177 6413311 ----- --------- http://georg.hronopik.de -------------
signature.asc
Description: This is a digitally signed message part.
