>Hello: > >In the file filter_smartyuv.c at the row 292 there is the code if >(!(fmoving[x] = moving[x]) ) and at the row there is if ((moving[x] = >fmoving[x])). They are used for eroding and dilating. > >I think it may be a bug, because if they are done, the moving[x] will be >always set to 1, so the whole frame will be always intepolated ( or >blended). The idee of motion adaptive will be meaningless here. > >Why not "==" instead of "="?
You overlooked the line: "fmoving[x] = (sum > 128);" where fmoving[x] can be reset to 0; also, if you look higher up in the file, the MMX version of the code uses a memcpy() to copy from moving[] to fmoving[]. So the first assignment "fmoving[x] = moving[x]" is correct, though it's arguably bad style. The second assignment may be incorrect, but I don't know enough about the filter module to say one way or the other, so as long as it works it's probably best not to change it. --Andrew Church [EMAIL PROTECTED] http://achurch.org/