Op Donderdag 2007-09-06 skryf lars: > Hi, > > > > > Perhaps the one thing that might not be obvious is the explanation of > > > > ABSOLUTE_LOCATION. Someone reading it won't necessarily know what > > > > self.location or "the base directory" is. But now I'm being really > > > > difficult :-) > > > > > > I would see three possible solutions here: > > > > > > 1) improving the comments > > > > > > 2) providing "self.location_relative" and "self.location_absolute" > > > > > > 3) making "self.location" always relative to the base directory of the > > > local > > > working copy - but since all RCS except for "git" use absolute paths, this > > > would bloat the code a slightly bit > > > > > > any opinions? > > > > > > > I'm happy with 1 - but even 0 (doing nothing) wouldn't bother me > > much :-) > > after some thinking, I decided to take choose the second one. It should be > easier to understand for others and it makes ABSOLUTE_LOCATION obsolete. > > The new patch (it includes the former one) additionally fixes the > following issues: > - the darcs implementation (as discussed with Miklos) > - the docstring improvement (as suggested by Friedel) > - raise NotImplementedError for missing functions (also suggested by Friedel) > > The basic tests with "getcleanfile" work for all supported systems. > > Any opinions? >
I committed it on SVN trunk with revision 6420. I think I might have changed a docstring or two, but now I can't remember if I removed my changes. Please shout if I did anything irresponsible :-) I am a bit disappointed: the epydoc documentation doesn't include the variable descriptions. The method I suggested is mentioned here: http://epydoc.sourceforge.net/manual-docstring.html but doesn't work with my version here (2.1). I hope I didn't recommend it incorrectly :-) Anyway, thanks for all the work. F ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Translate-pootle mailing list Translate-pootle@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/translate-pootle
