On Thu, Jun 13, 2013 at 05:07:59PM -0400, Vince Weaver wrote:
> On Thu, 13 Jun 2013, Dave Jones wrote:
> >
> > Probably safer ?
> >
> > + *type = rand32() | 1;
> > + *config1 = rand64() | 1;
> > + return rand64() | 1;
>
> no, 0 is a perfectly valid value for all of those fields.
>
> The error was coming in to play because if sysfs wasn't found, num_pmus
> was set to 0, and we were doing a " rand() % num_pmus " to choose
> a random value for the type field.
ah, gotcha. I'll queue up your patch.
thanks,
Dave
--
To unsubscribe from this list: send the line "unsubscribe trinity" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html