On Sun, Jun 02, 2013 at 09:50:57PM +0200, Oleg Nesterov wrote: > This patch simply moves all per-cpu variables into the new single > per-cpu "struct bp_cpuinfo". > > To me this looks more logical and clean, but this can also simplify > the further potential changes. In particular, I do not think this > memory should be per-cpu, it is never used "locally". After this > change it is trivial to turn it into, say, bootmem[nr_cpu_ids]. > > Signed-off-by: Oleg Nesterov <[email protected]>
I'm ok with the patch because it's indeed more logical and clean to pack the info to a single struct. But I'm not sure why you think using per-cpu is a problem. It's not only deemed for optimized local uses, it's also convenient for allocations and de-allocation, or static definitions. I'm not sure why bootmem would make more sense. Other than this in the changelog, the patch is nice, thanks! Acked-by: Frederic Weisbecker <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe trinity" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
