On 23 March 2012 10:56, Jan Kundrát <[email protected]> wrote: > > Hi Mildred, there turned out to be a performance problem with this > approach. The code did not check whether the index which got changed was > actually the one of the current message, and would update the > TagListWidget anyway. This was not an issue before, but now I've added > an explicit dataChanged() when flags of any message change (which is > required for proper operation of the GUI when displaying threads), > including during the mailbox sync. As a result of that, when I opened a > message, left it visible in the message view and switched to another > mailbox with, say, 10k of messages, the TagListWidget would be updated > 10k times. Just FYI; I haven't noticed that when reviewing, either. > Changed in 344bc91b25e9b0a9c28bcd017ade191e8a1ac32f. >
I thought it could happen in theory, but never in practice. I already developped an application that made heavy use of dataChanged() signals, and over time, we switched to make sure we only updated the view when necessary. I just didn't think of the case where the message is opened in a new window. It shouldn't be very difficult, please feel free to change that. I'd be more confortable not to have to do this soon because I have a lot of thigs to do. I first need to create an electronic watchdog to reboot my server when (like now) it shuts down for no obvious reason. And I am pretty busy on other fronts as well. If I have time next week, I might give a hand though. > > I thought that these special flags (starting with \ or $) should be > > hidden by default. But I did not implement that. > > Not that this is a huge issue, but it enables users to click on the [x] > button for system flags like \Recent which leads to the IMAP server > responding with a BAD response (which essentially means "hey you, > client, you've sent some garbage here"). I've opened a bugreport [1] for > that. > With the current state of the flag view, I consider the responsability of the user to deal with these flags with care. It was also good to test that the flags were actually changed. As I said, don't wait for me. The fix is not very difficult either. Thank you, Mildred PS: If I don't respond to the e-mails, don't hesitate to send a mail at [email protected] (you can remove the -pub, it's for spam bots mostly)
