On 10/07/12 22:12, Thomas Lübking wrote:
- TB renders them as "<b>*bold*</b>" (ie. including the star,
underscore or a slash) while Trojita shows them as "<b>bold</b>". I
like TB's way more.
Frankly: I don't like that at all (actually "accidentally" happened
on first try and I fixed that as fast as possible =) The current
implementation allows for both via css. -> should the user be allowed
to provide a custom stylesheet
("~/.config/flaska.net/trojita_mail.css") or should we generate it
from some settings?
Well, I like them, you don't like them. That's two high profile users
each willing to push the feature in a different way. A user-visible
settings is needed, I'd say.
- there's an extra newline between the added "on ..., ... wrote"
and the quoted message
I removed it, but it actually was intentionally there. Not sure
whether i like the editor w/o.
This is again a matter of personal style. Most MUAs allow the user to
configure the string used as a template for quotation -- and I like that.
I haven't tested replying to HTML e-mails.
I've clicked "reply" on a mail from reviewboard, but it seems the
quotes are in this case lost. I assume in the end you'd like
interpreting the blockquote tags as quotemarks?
I've tried to search for what the usual way of working with HTML mail is
some time ago and that's what I've read, yep.
the old-school plaintext stuff, supports some fancy features like
interactive collapsing of big quotations by mouse clicks
That would require JS, would it? In that case i could rather resist.
(JS in a push medium sounds like a /very/ bad idea)
I don't want to allow sender-defined JavaScript to execute, either. I,
however, also receive lots of mails where there's a ton of quoted text,
and I'd like my computer to "help me" deal with them. Let's postpone
this feature for later.
It's going to be tricky as it will likely require
QWebView::selectedHtml()
This direction? No.
Clever -- I like that. I suspect this will break later on, though (like
when replying to HTML mail).
One thing which is badly missing are unit tests for this
Like a test mail? A automatic unittest would require to move the
markup stuff into an extra function, returning a string, then pass it
a testcontent, remove all expected tagged items and check that the
result is empty. Where do you keep unit tests and where do you want
the function to reside?
Automated tests are in the tests/tests/ directory of the source tree.
OK, I'll take care of this.
I'm not particularly happy for the loadFinished ->
slotMarkupPlainText connection,
Me neither, but we'd have to add the entire protocol stuff using
QNetworkRequest replacing QWebView::load() I don't mind that, but
felt the change to be out of scope (to massive impact) in this
regard.
Note that the QNAM is already utilized behind the scenes. Yes, adding
yet another QNAM for formatting is some extra work. I'll think about
what is worse.
There's an outstanding issue that worries me, being the editor. One
can either wrap on a static width (tried, sucks), not at all (sucks
more) or wordwrap on the widget size (default, not ideal either?) ->
should we wrap the text on sending it or seek to "fix" wrapping in
QTextEdit? (to support older mail clients)
This is very closely related to format=flowed again. My requirements are:
- conform to the standards,
- utilize format=flowed for "normal" operation (ie. the resulting text
should wrap dynamically for the receivers),
- make it possible for the user to force manual breaks, e.g. for code
snippets
I don't know if it's a good thing to have the text wrap even in the
composer -- TB works this way, and it uses "dynamic" and automatic
wrapping (when I delete something on the previous line, this line gets
"merged" with the previous line partially). I guess that's how it should
be done.
From 1d3b9ce54a0002377a855fd3ceb12c1e18c2a8b6 Mon Sep 17 00:00:00
2001 From:
=?UTF-8?q?Thomas=20L=C3=BCbking?=<[email protected]> Date:
Sun, 7 Oct 2012 21:08:46 +0200 Subject: [PATCH 1/3] more complex
markup
This patch hides the ">" marks -- I don't like that. Fixed in 4c6d722.
I have mixed feeling about the 90% font size, it makes the nested
replies *very* small. I'll give it a try for a few days, see if I like
that or not.
The first patch and the replacement for the second patch are both in,
thanks for them.
With kind regards,
Jan
--
Trojita, a fast e-mail client -- http://trojita.flaska.net/
