On 10/14/12 15:46, Thomas Lübking wrote:
I finally figured how to false positively send by ctrl+enter -
happens if you quickly enter (newline) and then use some
ctr+something shortcut (usually ctrl+v)

Good job; I can reproduce it here as well.

+#define IS_SEND_COMBO \
+((ke->key() == Qt::Key_Return || ke->key() == Qt::Key_Enter) && 
ke->modifiers() == Qt::ControlModifier)
+

Could you please make it a private method instead?

+    static QDateTime lastVersion;
+    QDateTime lastTouched(file.exists() ? QFileInfo(file).lastModified() : 
QDateTime());
+    if (lastVersion < lastTouched) {

If I'm reading this correctly, this will evaluate to true every time this funciton is called when the file is missing. Could you please fix that?

Cheers,
Jan
--
Trojita, a fast e-mail client -- http://trojita.flaska.net/

Reply via email to