On Tuesday, 7 May 2013 16:58:13 CEST, Yasser Aziza wrote:
code updated on git.
(Adding the ML back into Cc; this is a technical discussion which shall happen in the open.) Added some comments on the merge request [1]. After you'll have changed this biggest problem, please squash your changes into a single commit (perhaps rebased on top of recent master for simplicity) and submit this for a review. This is needed because at this point, the history contains a lot of commits which introduce broken behavior. In order to make it possible to track down bugs through `git rebase`, having a clean history is crucial. If you need help, just ask. There will likely be a couple of whitespace issues (I see some in the aggregated diff), but it'll be easier to fix them when the squashing is done. With kind regards, Jan [1] https://gitorious.org/trojita/trojita/merge_requests/19 -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
