2013/5/21 Francesco Riosa <[email protected]>

>
>
>
> -------- Original Message --------
> On Sunday, 19 May 2013 22:05:02 CEST, Francesco Riosa wrote:
> > Beforegoing on and polish the code I would like to hear if the
> > directionis the right one.
>
> Hi Francesco,
> thanks for taking the time to write this. I agree with the other people
> on the list (you might want tosubscribe to receive these replies, in the
> meanwhile, see [1])


Here we are

having a combobox for account selection is not
> something that I particularly like. Could you please make it similar in
> appearance to the way how the sender identities are configured?
>


It was not totally satisfying for me too but it was easy and fast, I will
try to mimic the account selection next


>
> > In config file accounts section should have a common prefix IMHO, "imap"
> > has been chosen for this example but a more sensible should be chosen.
> > Or we should try something more hierarchical?
>
> This is already done in the multiaccounts-2 branch (see
> multiaccounts-2:src/Gui/Window.cpp). What was missing is the GUI for
> configuring this.
>

missed that, will look more closely


> > The patch has been developed against trojita-multiaccounts branch with
> > commits from master branch up to ~v0.3.93
>
> Could you please push what you have done to some git repo? I suspect
> that even solving the conflicts would not be that easy, so I'd like to
> use what you've done so far.
>

it's @ https://github.com/vivo75/trojita-multiaccounts.git

Not that I would use it; the merge has been done without paying attention
at real program functionality, just to work on more recent codebase. A
compilable and with basic functionality codebase  which permitted to read a
few message and show the config dialog.

Between multiaccount and master there was a delta of circa 200 commits and
only 3 conflicts.

I'm no expert in git merges, I do use it mainly as a filesystem with a
memory, if you need a more reliable merge I volunteer for that but suggest
to suggest me the appropriate procedure and traps to be encountered.


>
> Cheers,
> Jan
>
> [1] http://thread.gmane.org/gmane.mail.trojita.general/343
>
>

Reply via email to