On Monday, 2013-07-08, Pali Rohár wrote: > On Saturday 29 June 2013 16:02:59 Kevin Krammer wrote:
> > - AbookAddressbook has lots of public API that is not in > > AddressbookInterface (e.g. model). > > It is needed in AddressbookInterface (somewhere for Trojita)? Or > where is problem? AbookAddressbook is also used by be.contacts > standalone application, so that methods must be public for access > outside class. It might be better to separate this into two classes. One that implements the addressbook and one that implements the interface using an instance of that class. One reason is that anyone creating new plugins will look at the existing plugins and it would be better to clearly show which parts are the plugin and which are the code dealing with the actual data access behind the scenes. But it would be good to get the opinion of the ABook code creator/maintainer on this first. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring
signature.asc
Description: This is a digitally signed message part.
