On Wednesday, 14 August 2013 17:29:37 CEST, Pali Rohár wrote:
in my pali-gsoc branch there is IPC support via DBus. Trojita now export some functions via DBus: for opening main window, opening addressbook window and opening compose new mail window.

Cool -- great to see that you're making a good progress.

Does this work depend on what you've done plugin-wise? Right now, the total diffstat between master and your branch are 5381 added lines and 1994 removed ones; that's a *ton* of code to carefuly go through. What I'd like to request is having this work split into nice, atomic chunks which do not include unrelated changes on top of each other. Could you please do that, so that we can review one logical set of changes at a time?

When trojita is starting first it checking if there is another instance already running. If yes it will use IPC to do something (open main window or compose new mail...).

I made a quick look at how you do IPC. What surprised me was that you chose to implement empty stub functions for IPC instead of having the code #ifdefed -- why?

Trojita now support some command line arguments, mostly for specifing email headers for new email (to, cc, subject, body, ...) There is also support to pass mailto: url, but I looked into trojita code and there is limited support for mailto. Maybe this can be extended.

When I investigated how to do --mailto handling some months ago, I ended up reading through KDE's code to see how kdelibs, kdepim and kmail handled this. IIRC there was some special-casing for KMail for passing the subjects, addresses etc via distinct params while all other MUAs were only given an URL (with no loss of functionality) -- all of that is "IIRC". Are the individual options needed?

Kevin and how to tell KDE (or maybe other DE too) that trojita application is email client and mailto: argument can be passed via cmdline?

I asked about this on the xdg mailing list, see the thread [1] from November 2012. It should be just a matter of providing a correct .desktop file (and maybe a dedicated binary like e.g. `trojita-mailto-handler` or something).

Cheers,
Jan

[1] http://lists.freedesktop.org/pipermail/xdg/2012-November/012573.html

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/

Reply via email to