On Jan 26, 2010, at 2:22 PM, Klaus Heinrich Kiwi wrote: > On Tue, 2010-01-26 at 13:02 -0200, Rajiv Andrade wrote: >>> Change above introduced a lot of TPM_E_BAD_KEY_PROPERTY in the >>> testsuite. Reverting and adding a TODO note, since this conditional >>> obviously always fails >>> >>> Signed-off-by: Klaus Heinrich Kiwi <[email protected]> >>> --- >>> src/tspi/obj_rsakey.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/src/tspi/obj_rsakey.c b/src/tspi/obj_rsakey.c >>> index a3c857b..cd8c59a 100644 >>> --- a/src/tspi/obj_rsakey.c >>> +++ b/src/tspi/obj_rsakey.c >>> @@ -82,7 +82,7 @@ obj_rsakey_add(TSS_HCONTEXT tspContext, TSS_FLAG >> initFlags, TSS_HOBJECT *phObjec >>> break; >>> } >>> >>> - if (initFlags != TSS_KEY_EMPTY_KEY) >>> + if (initFlags & TSS_KEY_EMPTY_KEY) /* TODO: Check this >> logic */ >> >> Actually, the right logic is if (initFlags == TSS_KEY_EMPTY_KEY) >> >> Committing now, Thanks Klaus, >> -Rajiv > > So you're pushing the fixed version (i.e, initFlags == > TSS_KEY_EMPTY_KEY), right? > Right, it's on sourceforge already.
Thanks, Rajiv ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ TrouSerS-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/trousers-tech
