Yeah, worth taking this conversation over to tpmdd-devel. -Joel
On 11/05/2013 02:21 PM, Richard wrote: > Ceri, > > Couldn't find anything in the TSS. So, I still hold my opinion: it's the > device driver's responsibility to issue the TPM_NEEDS_SELFTEST command. > > Anyone else thinks different? Joel? > > Em 05-11-2013 09:37, Ceri Coburn escreveu: >> >> If you feel it should be added to tcsd let know how I can help, >> otherwise I can reach out to our hardware vendor to get ST to make the >> necessary changes to their tpm driver. >> >> >> >> *From:*Richard [mailto:[email protected]] >> *Sent:* 05 November 2013 11:32 >> *To:* [email protected] >> <mailto:[email protected]> >> *Subject:* [TrouSerS-tech] Fwd: Re: ST33 I2C TPM issues >> >> >> >> Copying to list, so others can give their opinions. >> >> >> >> -------- Mensagem original -------- >> >> *Assunto: * >> >> >> >> Re: [TrouSerS-tech] ST33 I2C TPM issues >> >> *Data: * >> >> >> >> Tue, 05 Nov 2013 09:31:21 -0200 >> >> *De: * >> >> >> >> Richard <[email protected]> <mailto:[email protected]> >> >> *Para: * >> >> >> >> Ceri Coburn <[email protected]> <mailto:[email protected]> >> >> >> >> Answers in line >> >> Em 05-11-2013 08:05, Ceri Coburn escreveu: >> >> After further investigation, error 0x801 is indeed >> TPM_NEEDS_SELFTEST. But is does stipulate in the TPM Main Part 3 >> Commands Specification under section 4.2 >> >> >> >> >> Nice. Looks like I overlooked this information. >> >> *Description* >> >> 1. Prior to executing the actions of TPM_ContinueSelfTest, if the TPM >> receives a command >> >> C1 that uses an untested TPM function, the TPM MUST take one of these >> actions: >> >> >> >> a. The TPM MAY return TPM_NEEDS_SELFTEST >> >> >> >> i. This indicates that the TPM has not tested the internal resources >> required to execute C1. >> >> ii. The TPM does not execute C1. >> >> iii. The caller MUST issue TPM_ContinueSelfTest before re-issuing the >> command C1. >> >> >> >> (1) If the TPM permits TPM_SelfTestFull prior to completing the >> actions of TPM_ContinueSelfTest, the caller MAY issue TPM_SelfTestFull >> rather than TPM_ContinueSelfTest. >> >> >> >> b. The TPM MAY return TPM_DOING_SELFTEST >> >> >> >> i. This indicates that the TPM is doing the actions of >> TPM_ContinueSelfTest implicitly, as if the TPM_ContinueSelfTest >> command had been issued. >> >> ii. The TPM does not execute C1 >> >> iii. The caller MUST wait for the actions of TPM_ContinueSelfTest to >> complete before reissuing the command C1. >> >> >> >> b. The TPM MAY return TPM_SUCCESS or an error code associated >> with C1. >> >> >> >> i. This indicates that the TPM has completed the actions of >> TPM_ContinueSelfTest and has completed the command C1. >> >> ii. The error code MAY be TPM_FAILEDSELFTEST. >> >> >> >> Please forgive the formatting, cut and paste from Acrobat wasn’t >> forgiving. >> >> >> >> With that in mind, should it not be the job of the tcsd daemon to >> execute TPM_SelfTestFull/TPM_ContinueSelfTest if the initial >> GetCapability command fails with TPM_NEEDS_SELFTEST? I’m happy to >> look into this and supply patches if necessary. >> >> >> >> >> To answer this, I'll have to read the TSS documentation to see if >> there is any explicit mention to that. >> >> However, it looks a device driver specific attribution to me. >> >> Regards, >> >> Ceri >> >> >> >> *From:*Richard [mailto:[email protected]] >> *Sent:* 04 November 2013 17:45 >> *To:* [email protected] >> <mailto:[email protected]> >> *Subject:* Re: [TrouSerS-tech] ST33 I2C TPM issues >> >> >> >> Ceri, >> >> I found this by searching on google: >> https://groups.google.com/a/chromium.org/forum/#!topic/chromium-os-checkins/iJjc8Mzzzow >> <https://groups.google.com/a/chromium.org/forum/#%21topic/chromium-os-checkins/iJjc8Mzzzow> >> >> Looks like it's a known characteristic of STM TPMs, which needs to run >> the self test after resume operations. >> >> I suggest you take a look at the kernel source of your system and >> check if the changes mentioned in this thread were applied to your kernel. >> >> Em 04-11-2013 13:49, Richard escreveu: >> >> Hi Ceri, >> >> >> >> I saw something about it in the tpm-dd mailing list. I'll investigate >> >> and get back to you if I find something. >> >> >> >> Em 02-11-2013 10:02, Ceri Coburn escreveu: >> >> Hi All, >> >> >> >> Up until now I have been using the TPM emulator project for >> >> interfacing with a TPM which has worked great. I am now in the >> >> process of starting to test my TPM unit tests on a real TPM that we >> >> intend on using for our project. >> >> >> >> Upon starting the tcsd daemon it fails instantly with the following >> output. >> >> >> >> TCSD tcsd_conf.c:94 platform_class_list_append: >> >> platform_class_list_append start: >> >> TCSD tcsd_conf.c:126 platform_class_list_append: Platform Class >> Added. >> >> TCSD TCS tcsi_caps_tpm.c:43 Entering Get Cap >> >> To TPM: 00 C1 00 00 00 12 00 00 00 65 00 00 00 1A 00 00 >> >> To TPM: 00 00 >> >> TCSD TDDL tddl.c:171 Calling write to driver >> >> TCSD TDDL tddl.c:188 ioctl: (25) Inappropriate ioctl for device >> >> TCSD TDDL tddl.c:189 Falling back to Read/Write device support. >> >> >From TPM: 00 C4 00 00 00 1E 00 00 00 00 00 00 00 10 00 30 >> >> >From TPM: 01 02 0D 0A 00 02 03 53 54 4D 20 00 01 4B >> >> TCSD TCS tcsi_caps_tpm.c:43 Entering Get Cap >> >> To TPM: 00 C1 00 00 00 16 00 00 00 65 00 00 00 01 00 00 >> >> To TPM: 00 04 00 00 00 B4 >> >> TCSD TDDL tddl.c:171 Calling write to driver >> >> >From TPM: 00 C4 00 00 00 0A 00 00 08 01 >> >> LOG_RETERR TPM tcsi_caps_tpm.c:52: 0x801 >> >> TCSD TCS ERROR: tcs_caps.c:191 TCS GetCapability failed with result >> = 0x801 >> >> >> >> Would anyone know if this a problem with the ST33 TPM driver or >> >> something inside TrouSerS? >> >> >> >> Thanks. >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Android is increasing in popularity, but the open development >> platform that >> >> developers love is also attractive to malware creators. Download >> this white >> >> paper to learn more about secure code signing practices that can >> help keep >> >> Android apps secure. >> >> >> http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk >> >> _______________________________________________ >> >> TrouSerS-tech mailing list >> >> [email protected] >> <mailto:[email protected]> >> >> https://lists.sourceforge.net/lists/listinfo/trousers-tech >> >> >> >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Android is increasing in popularity, but the open development platform >> that >> >> developers love is also attractive to malware creators. Download this >> white >> >> paper to learn more about secure code signing practices that can help >> keep >> >> Android apps secure. >> >> >> http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk >> >> _______________________________________________ >> >> TrouSerS-tech mailing list >> >> [email protected] >> <mailto:[email protected]> >> >> https://lists.sourceforge.net/lists/listinfo/trousers-tech >> >> >> >> >> >> ______________________________________________________________________ >> This email has been scanned by the Symantec Email Security.cloud service. >> For more information please visit http://www.symanteccloud.com >> ______________________________________________________________________ >> >> >> >> >> >> ______________________________________________________________________ >> This email has been scanned by the Symantec Email Security.cloud service. >> For more information please visit http://www.symanteccloud.com >> ______________________________________________________________________ >> >> >> >> ------------------------------------------------------------------------------ >> November Webinars for C, C++, Fortran Developers >> Accelerate application performance with scalable programming models. Explore >> techniques for threading, error checking, porting, and tuning. Get the most >> from the latest Intel processors and coprocessors. See abstracts and register >> http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk >> >> >> _______________________________________________ >> TrouSerS-tech mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/trousers-tech > > > > ------------------------------------------------------------------------------ > November Webinars for C, C++, Fortran Developers > Accelerate application performance with scalable programming models. Explore > techniques for threading, error checking, porting, and tuning. Get the most > from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk > > > > _______________________________________________ > TrouSerS-tech mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/trousers-tech > ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ TrouSerS-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/trousers-tech
