hi list,

ran into an issue with trousers 0.3.10 today: 0.3.8 was working fine, 
0.3.10 was rejecting every connection attempt by the tpm_* tools. After 
some debugging and comparing 0.3.9 to 0.3.10 I found the following 
difference:

--- trousers-0.3.10/src/tcs/rpc/tcstp/rpc.c     2012-09-25 
21:34:47.000000000 +0200
+++ trousers-0.3.10jjk/src/tcs/rpc/tcstp/rpc.c  2013-03-14 
17:05:05.262265979 +0100
@@ -618,8 +618,9 @@
 TSS_RESULT
 getTCSDPacket(struct tcsd_thread_data *data)
 {
-       if (data->comm.hdr.packet_size !=
-           (UINT32)(data->comm.hdr.parm_offset + 
data->comm.hdr.parm_size)) {
+       if (data->comm.hdr.num_parms > 0 &&
+               data->comm.hdr.packet_size !=
+               (UINT32)(data->comm.hdr.parm_offset + 
data->comm.hdr.parm_size)) {
                LogError("Invalid packet received by TCSD");
                return TCSERR(TSS_E_INTERNAL_ERROR);
        }

that is, 03.10 no longer has the check whether
  data->comm.hdr.num_parms > 0

which was present in 0.3.9; the above patch re-introduces the check and 
now tcsd 0.3.10 is communicating nicely with tpm-tools-1.3.8 again.

Am I the first person to run into this?

TIA,

JJK





------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
TrouSerS-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/trousers-users

Reply via email to