>+ char buf[4096] = {0};
>+ int olderr;
>+
>+ /* Disable logging to of "Bad Mode" during this call. If we're on a 1.1
TPM, it'd throw an >error
>+ * Save data sent to stderr in case it was any other type of error. */
>+ olderr = capture_stderr(buf, sizeof(buf));
capture_stderr() was defined to have no input arguments, which you passed
in the buf and sizeof(buf) there. Did you forget to get rid of them?
Another question is the handling of int overflow. Just wondering what's
the reason behind the chosen number '100'?
Vicky
On Wed, Aug 20, 2014 at 10:32 AM, Thomas Habets <[email protected]> wrote:
> The library writes logs to stderr. Instead of rewriting the logging
> framework to be able to redirect, this will redirect stderr
> temporarily, and will swallow the error only if it's the type of error
> we want to swallow.
>
> Attached is a patch with a couple of more comments.
>
> On 20 August 2014 13:14, Ken Goldman <[email protected]> wrote:
> > There's evidently something clever going on with stderr. My sense is
> > that it's something you've used before, so it's familiar to you. How
> > about some comments on the clever parts, for future maintainers?
> >
> > On 8/14/2014 4:42 AM, Thomas Habets wrote:
> >> My TPM chip got out of whack (I'm going to try a reboot), but in the
> >> mean time here's a patch to make tpm_version not fail silently.
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Slashdot TV.
> > Video for Nerds. Stuff that matters.
> > http://tv.slashdot.org/
> > _______________________________________________
> > TrouSerS-users mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/trousers-users
>
>
>
> --
> typedef struct me_s {
> char name[] = { "Thomas Habets" };
> char email[] = { "[email protected]" };
> char kernel[] = { "Linux" };
> char *pgpKey[] = { "http://www.habets.pp.se/pubkey.txt"; };
> char pgp[] = { "A8A3 D1DD 4AE0 8467 7FDE 0945 286A E90A AD48 E854" };
> char coolcmd[] = { "echo '. ./_&. ./_'>_;. ./_" };
> } me_t;
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds. Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> TrouSerS-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/trousers-users
>
>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
TrouSerS-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/trousers-users
