http://codereview.appspot.com/1860047/diff/5001/6002
File work.py (right):

http://codereview.appspot.com/1860047/diff/5001/6002#newcode27
work.py:27: self.parent = copy.copy(self.parent)
On 2010/08/30 00:59:35, pheller wrote:
ced: Is this needed?  Doesn't this just assign self.parent to a week
copy of
itself?
parent is a class attribute so we must copy it to not change it on all
TimesheetWork instance in every pool.

http://codereview.appspot.com/1860047/diff/5001/6002#newcode29
work.py:29: self.parent.context['type'] = Eval('type')
On 2010/08/30 00:59:35, pheller wrote:
??

This is an other context

http://codereview.appspot.com/1860047/diff/5001/6002#newcode81
work.py:81: if context.get('type') == 'project':
On 2010/08/30 00:59:35, pheller wrote:
On 2010/08/29 23:40:54, zodman wrote:
> Transaction().context.get('type') ... must be ?

Yes, right.

Fixed but next time fill an issue in the roundup when the codereview is
closed

http://codereview.appspot.com/1860047/

--
[email protected] mailing list

Reply via email to