On 27/01/11 18:38 +0100, Mathias Behrle wrote:
> * Betr.: " [tryton-dev] Display deleted lines in One2Many and Many2Many
>   (issue3977047)" (Thu, 27 Jan 2011 17:24:09 +0100):
> 
> > This is a patch that display deleted and removed lines in one2many and 
> > many2many. Those lines will appear greyed, once removed the delete 
> > button will turn to an undelete button allowing you to change your 
> > mind.
> 
> Just some thoughts without having time to test at once:
> 
> - Is this a switchable behavior? What will I do, if I don't want to see 
> deleted
>   lines?

No. I think it is a better behavior as there is no confirmation for deleted
lines in xxx2many.
If you don't want to see deleted lines, just save the record they will be
gone.

> - What will happen, when I want to delete just some more lines, but I get
>   presented the undelete button?

The button change depending of the line selected.
(I put a comment to fix the patch on multi-selection)

>   Shouldn't this be rather an additional button
>   instead of replacing the delete button?

It is the case but they are only show when needed.

>   What will happen otherwise with the
>   shortcuts related to the button?

It was missing (added comment).

>   Are they inversed, too? 

I don't think it is a good behavior. I thing about "Insert"

> Since this feature implements 'recycle bin'-behaviour, it should be in any 
> case
> switchable.

It doesn't change anything to the current behavior of the client.
It just add the possibility to undelete a line if you delete it before you
save the record.

> Also should a recycle bin be shown instead of the delete symbol, if
> this feature is activated.

There is no such icon in Tango. And by the way, I think there is no
distinction between delete and recycle in the freedesktop icon naming.


-- 
Cédric Krier

B2CK SPRL
Rue de Rotterdam, 4
4000 Liège
Belgium
Tel: +32 472 54 46 59
Email/Jabber: [email protected]
Website: http://www.b2ck.com/

Attachment: pgpbOLktDORHr.pgp
Description: PGP signature

Reply via email to